Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: jburwell <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-718-cloudstack@git.apache.org>
In-Reply-To: <git-pr-718-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup
 linklocal ...
Content-Type: text/plain
Message-Id: <20150819162823.5C5EDE35DB@git1-us-west.apache.org>
Date: Wed, 19 Aug 2015 16:28:23 +0000 (UTC)

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/718#discussion_r37435429
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java ---
    @@ -287,7 +287,7 @@ private void deleteExitingLinkLocalRouteTable(String linkLocalBr) {
                 for (String line : lines) {
                     String[] tokens = line.split(" ");
                     if (!tokens[2].equalsIgnoreCase(linkLocalBr)) {
    --- End diff --
    
    Consider the following as a bit of extra safety in the event of malformed input beginning at line 289:
    
    ```
    if (tokens != null && tokens.length < 2) {
       continue;
    }
    
    final String device = tokens[2];
    if (!Strings.isNullOrEmpty(device) &&
        !device.equalsIgnoreCase(linkLocalBr)) {
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---