Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DB6618E2E for ; Wed, 19 Aug 2015 15:53:07 +0000 (UTC) Received: (qmail 27852 invoked by uid 500); 19 Aug 2015 15:53:02 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 27799 invoked by uid 500); 19 Aug 2015 15:53:02 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 27788 invoked by uid 99); 19 Aug 2015 15:53:01 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 15:53:01 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C363FDFA25; Wed, 19 Aug 2015 15:53:01 +0000 (UTC) From: borisroman To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Changed AddressFormat elements to reflect... Content-Type: text/plain Message-Id: <20150819155301.C363FDFA25@git1-us-west.apache.org> Date: Wed, 19 Aug 2015 15:53:01 +0000 (UTC) Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/716#issuecomment-132646596 @remibergsma You are correct. Those are all not related to the AddressFormat enum. Of course all should be renamed, but doing so in 1 time will also will not benefit the process of making the code more readable. I'll will stack up some commits before making a new pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---