Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BB101898B for ; Tue, 18 Aug 2015 12:00:23 +0000 (UTC) Received: (qmail 95570 invoked by uid 500); 18 Aug 2015 12:00:22 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 95518 invoked by uid 500); 18 Aug 2015 12:00:22 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 95507 invoked by uid 99); 18 Aug 2015 12:00:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Aug 2015 12:00:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6BB4ADFDD7; Tue, 18 Aug 2015 12:00:22 +0000 (UTC) From: anshul1886 To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB... Content-Type: text/plain Message-Id: <20150818120022.6BB4ADFDD7@git1-us-west.apache.org> Date: Tue, 18 Aug 2015 12:00:22 +0000 (UTC) Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/700#issuecomment-132186831 @DaanHoogland That doesn't seems to be the case here. I believe if somebody has to change unit test with every change then that unit test is burden and should not be kept in codebase. I still didn't get the real purpose here as your statement starts with if. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---