Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: remibergsma <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-351-cloudstack@git.apache.org>
In-Reply-To: <git-pr-351-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: This branch implements the CSV and
 native...
Content-Type: text/plain
Message-Id: <20150817070203.4DCA5DFCCE@git1-us-west.apache.org>
Date: Mon, 17 Aug 2015 07:02:03 +0000 (UTC)

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/351#issuecomment-131701094
  
    @devdeep Did you LGTM on this? Were you able to test / verify it with a hyper-v cluster?
    
    @anshul1886 Can you look at the commits and see if you can squash some of them? I'm not saying it should be one commit, but I do want them to be atomic. Also, I don't see any tests for this? How are we going to make sure this keeps working once it is merged?
    
    Pinging @karuturi @DaanHoogland to see if they can review the code as I'm not a Java guru. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---