Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: mike-tutkowski <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-654-cloudstack@git.apache.org>
In-Reply-To: <git-pr-654-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Cloudstack 8656: do away with more
 silent...
Content-Type: text/plain
Message-Id: <20150811174416.510DEE024E@git1-us-west.apache.org>
Date: Tue, 11 Aug 2015 17:44:16 +0000 (UTC)

Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/654#discussion_r36774764
  
    --- Diff: services/console-proxy/server/src/com/cloud/consoleproxy/vnc/packet/server/RawRect.java ---
    @@ -50,26 +52,27 @@ public void paint(BufferedImage image, Graphics2D graphics) {
     
             switch (dataBuf.getDataType()) {
     
    -            case DataBuffer.TYPE_INT: {
    -                // We chose RGB888 model, so Raster will use DataBufferInt type
    -                DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
    +        case DataBuffer.TYPE_INT: {
    +            // We chose RGB888 model, so Raster will use DataBufferInt type
    +            DataBufferInt dataBuffer = (DataBufferInt)dataBuf;
     
    -                int imageWidth = image.getWidth();
    -                int imageHeight = image.getHeight();
    +            int imageWidth = image.getWidth();
    +            int imageHeight = image.getHeight();
     
    -                // Paint rectangle directly on buffer, line by line
    -                int[] imageBuffer = dataBuffer.getData();
    -                for (int srcLine = 0, dstLine = y; srcLine < height && dstLine < imageHeight; srcLine++, dstLine++) {
    -                    try {
    -                        System.arraycopy(buf, srcLine * width, imageBuffer, x + dstLine * imageWidth, width);
    -                    } catch (IndexOutOfBoundsException e) {
    -                    }
    +            // Paint rectangle directly on buffer, line by line
    +            int[] imageBuffer = dataBuffer.getData();
    +            for (int srcLine = 0, dstLine = y; srcLine < height && dstLine < imageHeight; srcLine++, dstLine++) {
    +                try {
    +                    System.arraycopy(buf, srcLine * width, imageBuffer, x + dstLine * imageWidth, width);
    +                } catch (IndexOutOfBoundsException e) {
    +                    s_logger.info("[ignored] buffer overflow!?!", e);
                     }
    -                break;
                 }
    +            break;
    --- End diff --
    
    I guess it's OK. It looks like it would fix a bug (the for loop would only execute at most once before).
    
    If you're OK with it, I'm OK with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---