Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: nitt10prashant <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-665-cloudstack@git.apache.org>
In-Reply-To: <git-pr-665-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of
 snaps...
Content-Type: text/plain
Message-Id: <20150811113658.DCEC5E0009@git1-us-west.apache.org>
Date: Tue, 11 Aug 2015 11:36:58 +0000 (UTC)

Github user nitt10prashant commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/665#discussion_r36735392
  
    --- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
    @@ -0,0 +1,279 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +""" Test case for Multiple Volume Snapshot in ZWPS
    +"""
    +from nose.plugins.attrib import attr
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.lib.utils import (cleanup_resources,
    +                              validateList)
    +from marvin.lib.base import (Account,
    +                             ServiceOffering,
    +                             DiskOffering,
    +                             Snapshot,
    +                             VirtualMachine,
    +                             StoragePool
    +                             )
    +from marvin.lib.common import (get_domain,
    +                               get_zone,
    +                               list_volumes,
    +                               list_clusters,
    +                               get_template
    +                               )
    +
    +from marvin.codes import PASS, ZONETAG1, ROOT, DATA
    +
    +
    +class TestMultipleVolumeSnapshots(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        testClient = super(TestMultipleVolumeSnapshots, cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls.testdata = testClient.getParsedTestDataConfig()
    +
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +        cls.hypervisor = cls.testClient.getHypervisorInfo()
    +        cls.template = get_template(
    +            cls.apiclient,
    +            cls.zone.id,
    +            cls.testdata["ostype"])
    +
    +        cls._cleanup = []
    +
    +        cls.skiptest = False
    +
    +        clus_list = list_clusters(cls.apiclient)
    +
    +        if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
    +            cls.skiptest = True
    +            return
    +
    +        try:
    +            # Create an account
    +            cls.account = Account.create(
    +                cls.apiclient,
    +                cls.testdata["account"],
    +                domainid=cls.domain.id
    +            )
    +
    +            # Create user api client of the account
    +            cls.userapiclient = testClient.getUserApiClient(
    +                UserName=cls.account.name,
    +                DomainName=cls.account.domain
    +            )
    +            # Create Service offering
    +            cls.service_offering_zwps = ServiceOffering.create(
    +                cls.apiclient,
    +                cls.testdata["service_offering"],
    +                tags=ZONETAG1
    +            )
    +
    +            cls.disk_offering_zwps = DiskOffering.create(
    +                cls.apiclient,
    +                cls.testdata["disk_offering"],
    +                tags=ZONETAG1
    +            )
    +
    +            cls._cleanup = [
    +                cls.account,
    +                cls.service_offering_zwps,
    +                cls.disk_offering_zwps,
    +            ]
    +        except Exception as e:
    +            cls.tearDownClass()
    +            raise e
    +        return
    +
    +    @classmethod
    +    def tearDownClass(cls):
    +        try:
    +            cleanup_resources(cls.apiclient, cls._cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +
    +    def setUp(self):
    +
    +        self.cleanup = []
    +        if self.skiptest:
    +            self.skipTest("Skip test as setup is either not VMWare or  \
    +                    having less than 2 clusters %s" % self.hypervisor)
    +
    +        self.apiclient = self.testClient.getApiClient()
    +        self.dbclient = self.testClient.getDbConnection()
    +        self.pools = []
    +
    +    def tearDown(self):
    +        try:
    +            for storagePool in self.pools:
    +                StoragePool.update(self.apiclient, id=storagePool.id, tags="")
    +
    +            cleanup_resources(self.apiclient, self.cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +        return
    +
    +    @attr(tags=["advanced", "basic"], required_hardware="true")
    +    def test_01_multiple_snapshot_in_zwps(self):
    +        """ Test multiple volume snapshot in zwps
    +
    +        # 1. Verify if setup has a ZWPS and 2 CWPS
    +        # 2. Deploy a VM with data disk in ZWPS
    +        # 1. Verify ROOT and DATA Disk of the VM is in ZWPS.
    +        # 2. Take a snapshot of VM.
    +        # 3. Create Multiple Snapshots till operation fails.
    +        """
    +        try:
    +
    +            self.pools = StoragePool.list(self.apiclient, zoneid=self.zone.id)
    +            if len(list(storagePool for storagePool in self.pools
    +                        if storagePool.scope == "ZONE")) < 1:
    +                self.skipTest("There must be at least one zone wide\
    +                storage pools available in the setup")
    +
    +            if len(list(storagePool for storagePool in self.pools
    +                        if storagePool.scope == "CLUSTER")) < 2:
    +                self.skipTest("There must be at atleast two cluster wide\
    +                storage pools available in the setup")
    +        except Exception as e:
    +            self.skipTest(e)
    +
    +        # Adding tags to Storage Pools
    +        zone_no = 1
    +        self.debug("Storage Pools: %s" % self.pools)
    +        self.zone_pool = []
    +        for storagePool in self.pools:
    --- End diff --
    
    No need to tag  all the zone wide pool , only one tagged pool is enough for this test case .
    You can just update the 1st zone wide pool .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---