Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: nitt10prashant <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-667-cloudstack@git.apache.org>
In-Reply-To: <git-pr-667-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start
 instance...
Content-Type: text/plain
Message-Id: <20150811111228.071D9DFFA9@git1-us-west.apache.org>
Date: Tue, 11 Aug 2015 11:12:28 +0000 (UTC)

Github user nitt10prashant commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/667#discussion_r36733719
  
    --- Diff: test/integration/testpaths/testpath_restore_vm.py ---
    @@ -0,0 +1,201 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +"""
    +Test restore running VM on VMWare with one cluster having 2 Primary Storage
    +"""
    +
    +
    +from nose.plugins.attrib import attr
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.lib.utils import cleanup_resources
    +from marvin.lib.base import (Account,
    +                             ServiceOffering,
    +                             VirtualMachine,
    +                             StoragePool
    +                             )
    +from marvin.lib.common import (get_domain,
    +                               get_zone,
    +                               get_template,
    +                               list_volumes,
    +                               list_virtual_machines
    +                               )
    +
    +from marvin.codes import CLUSTERTAG1, ROOT
    +import time
    +
    +
    +class TestRestoreVM(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        testClient = super(TestRestoreVM, cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls.testdata = testClient.getParsedTestDataConfig()
    +        cls.hypervisor = cls.testClient.getHypervisorInfo()
    +
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +
    +        cls.template = get_template(
    +            cls.apiclient,
    +            cls.zone.id,
    +            cls.testdata["ostype"])
    +
    +        cls._cleanup = []
    +
    +        try:
    +            cls.skiptest = False
    +            if cls.hypervisor.lower() not in ["vmware"]:
    +                cls.skiptest = True
    +                return
    +
    +            # Create an account
    +            cls.account = Account.create(
    +                cls.apiclient,
    +                cls.testdata["account"],
    +                domainid=cls.domain.id
    +            )
    +            cls._cleanup.append(cls.account)
    +            # Create user api client of the account
    +            cls.userapiclient = testClient.getUserApiClient(
    +                UserName=cls.account.name,
    +                DomainName=cls.account.domain
    +            )
    +            # Create Service offering
    +            cls.service_offering_cwps = ServiceOffering.create(
    +                cls.apiclient,
    +                cls.testdata["service_offering"],
    +                tags=CLUSTERTAG1
    +            )
    +            cls._cleanup.append(cls.service_offering_cwps)
    +        except Exception as e:
    +            cls.tearDownClass()
    +            raise e
    +        return
    +
    +    @classmethod
    +    def tearDownClass(cls):
    +        try:
    +            cleanup_resources(cls.apiclient, cls._cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +
    +    def setUp(self):
    +
    +        self.cleanup = []
    +        if self.skiptest:
    +            self.skipTest("This test is to be checked on VMWare only \
    +                    Hence, skip for %s" % self.hypervisor)
    +
    +        self.apiclient = self.testClient.getApiClient()
    +        self.dbclient = self.testClient.getDbConnection()
    +
    +    def tearDown(self):
    +        try:
    +            cleanup_resources(self.apiclient, self.cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +        return
    +
    +    @attr(tags=["advanced", "basic"], required_hardware="true")
    +    def test_01_recover_VM(self):
    +        """ Test Restore VM on VMWare
    +            1. Deploy a VM without datadisk
    +            2. Restore the VM
    +            3. Verify that VM comes up in Running state
    +        """
    +        try:
    +            self.pools = StoragePool.list(
    +                self.apiclient,
    +                zoneid=self.zone.id,
    +                scope="CLUSTER")
    +
    --- End diff --
    
    use validate list  here and all other places wherever you are listing any object 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---