Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: koushik-das <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-666-cloudstack@git.apache.org>
In-Reply-To: <git-pr-666-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band
 migrate al...
Content-Type: text/plain
Message-Id: <20150807150424.44A77E02D3@git1-us-west.apache.org>
Date: Fri,  7 Aug 2015 15:04:24 +0000 (UTC)

Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/666#discussion_r36527589
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
    @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEvent(final StateMachine2.Transition<State, Vi
                     s_logger.info("Schedule a router reboot task as router " + vo.getId() + " is powered-on out-of-band. we need to reboot to refresh network rules");
    --- End diff --
    
    @DaanHoogland I see that you introduced RouterReprovisionOnOutOfBandMigration as part of commit b9dd67c383874ef7273205e0eac831de497bb02d. Wasn't this config just meant to decide between VR reboot and generating alert? But I see that both 'if' and 'else' conditions are different. Has something changed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---