Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 362E4186DE for ; Wed, 19 Aug 2015 12:48:41 +0000 (UTC) Received: (qmail 26392 invoked by uid 500); 19 Aug 2015 12:48:06 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 26337 invoked by uid 500); 19 Aug 2015 12:48:06 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 26324 invoked by uid 99); 19 Aug 2015 12:48:06 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 12:48:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 96B9A1AA7D9 for ; Wed, 19 Aug 2015 12:48:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, SPF_HELO_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id d249x4kjNmuZ for ; Wed, 19 Aug 2015 12:47:59 +0000 (UTC) Received: from SMTP.CITRIX.COM.AU (smtp.citrix.com.au [103.14.252.240]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 88879215D2 for ; Wed, 19 Aug 2015 12:47:57 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.15,709,1432598400"; d="scan'208,217";a="19405302" From: Anshul Gangwar To: "dev@cloudstack.apache.org" CC: =?utf-8?B?UmFmYWVsIFdlaW5nw6RydG5lcg==?= , Daan Hoogland Subject: Re: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB... Thread-Topic: [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB... Thread-Index: AQHQ2jMNzDCCTfHCP0C5NM0U+mmTdp4ST1kAgAAQXoCAADjjgIAABiwAgAAQDgCAABEkgA== Date: Wed, 19 Aug 2015 12:47:46 +0000 Message-ID: <07661B56-3514-4CF0-A505-7C06F99E6811@citrix.com> References: <20150819035620.D35BEE08EA@git1-us-west.apache.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_07661B5635144CF0A5057C06F99E6811citrixcom_" MIME-Version: 1.0 X-DLP: SIN1 --_000_07661B5635144CF0A5057C06F99E6811citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 TGV0IG1lIHN1bW1hcmlzZSB0aGUgdGVzdHMNCmNsYXNzIEEgew0KeCgpew0KcmV0dXJuIOKAnGTi gJ07ICBhIGNvbnN0YW50DQp9DQp9DQoNCnRlc3QNCg0KcD3igJxk4oCdDQpBc3NlcnQoIEEueCgp ID0gcCkNCg0KV2hpY2ggY2FuIGJlIHJlZHVjZWQgdG8NCg0KY2xhc3MgQSB7DQpxPeKAnGQiOw0K fQ0KDQpIZXJlIHEgaXMgcmVwbGFjZW1lbnQgZm9yIHggbWV0aG9kIGFzIGl0IGlzIG9ubHkgcmV0 dXJuaW5nIGEgY29uc3RhbnQNCg0Kbm93IHRlc3QgaXMNCnA94oCcZCINCmFzc2VydCAocD1xKQ0K DQpUbyBtZSB0aGlzIGJhc2ljYWxseSBwcm92ZXMgdGhhdCBqYXZhIGFzc2lnbm1lbnQgd29ya3Mg YW5kIG5vdGhpbmcgbW9yZSB0aGFuIHRoYXQuDQoNCkhlcmUgQSBjYW4gYmUgYW55IGNsYXNzLiBC dXQgaW4gdGhpcyBjb250ZXh0IGl0IGlzIHN1YmNsYXNzIG9mIHNvbWV0aGluZy4NCg0KSSBjYW7i gJl0IGV2ZW4gZmlndXJlIG91dCBob3cgc3VwZXIgY2xhc3MgY29taW5nIGludG8gcGljdHVyZSBp biB0ZXN0cyB3aGljaCB5b3UgYXJlIHRyeWluZyB0byBzYXkuDQoNClBsZWFzZSBleHBsYWluIGlu IGNvbnRleHQgb2YgYWJvdmUgZXhhbXBsZSBob3cgaXQgaXMgdGVzdGluZyBtb3JlIHRoYW4gamF2 YSBhc3NpZ25tZW50Lg0KDQpSZWdhcmRzLA0KQW5zaHVsDQoNCk9uIDE5LUF1Zy0yMDE1LCBhdCA1 OjE2IHBtLCBBbnNodWwgR2FuZ3dhciA8YW5zaHVsLmdhbmd3YXJAY2l0cml4LmNvbTxtYWlsdG86 YW5zaHVsLmdhbmd3YXJAY2l0cml4LmNvbT4+IHdyb3RlOg0KDQpDYW4geW91IHBvaW50IHRvIGFu eSByZWZlcmVuY2UvYmxvZyB3aGljaCBqdXN0aWZpZXMgd3JpdGluZyB0ZXN0cyBmb3IgdGhpcyBr aW5kIG9mIHNjZW5hcmlvPw0KDQpXaGF0IEkgY2FuIGluZmVyIGZyb20gdGhlc2UgdGVzdHMgaXMg dGhhdCB0aGF0IHRoZXJlIGFyZSB0d28gc2NlbmFyaW9zDQoxKSBNZXRob2Qgd2lsbCBub3QgY2hh bmdlDQogICBJbiB0aGF0IGNhc2UgaXQgZG9lc27igJl0IG1ha2Ugc2Vuc2UgdG8gcHV0IHRlc3Qg Zm9yIG5ldmVyIGNoYW5naW5nIG1ldGhvZC4NCjIpIE1ldGhvZCB3aWxsIGNoYW5nZQ0KICAgSW4g dGhhdCBjYXNlIHlvdSBoYXZlIHRvIGNoYW5nZSB0ZXN0IHRvIG1ha2UgaXQgcGFzcyBhbmQgdGhl biBhbHNvIGl0IGRvZXNu4oCZdCBtYWtlIHNlbnNlIGFzIHlvdSBoYXZlIHRvIGNoYW5nZSB0ZXN0 IHRvIG1ha2UgaXQgYWN0dWFsbHkgcGFzcy4NCg0KUmVnYXJkcywNCkFuc2h1bA0KDQoNCk9uIDE5 LUF1Zy0yMDE1LCBhdCA0OjE4IHBtLCBSYWZhZWwgV2VpbmfDpHJ0bmVyIDxyYWZhZWx3ZWluZ2Fy dG5lckBnbWFpbC5jb208bWFpbHRvOnJhZmFlbHdlaW5nYXJ0bmVyQGdtYWlsLmNvbT48bWFpbHRv OnJhZmFlbHdlaW5nYXJ0bmVyQGdtYWlsLmNvbT4+IHdyb3RlOg0KDQpAYW5zaHVsMTg4NiBJIHRv dGFsbHkgYWdyZWUgd2l0aCB5b3UgdGhhdCB0ZXN0cyBhcmUgbWVhbnQgdG8gdGVzdCBpbmRpdmlk dWFsLCBhbmQgYXMgeW91IHBvaW50ZWQgdGhlIGluZGl2aWR1YWwgY29kZSB0aGF0IHdlIHdhbnQg dG8gdGVzdCBpcyDigJxnZXRQYXRjaEZpbGVQYXRo4oCdLiBIb3dldmVyLCB0aGF0IG1ldGhvZCBp cyBhYnN0cmFjdCwgYW5kIGl0cyDigJxpbXBsZW1lbnRhdGlvbuKAnSB0aGF0IGlzIGFzIHNpbXBs ZSBhcyByZXR1cm5pbmcgYSBjb25zdGFudCwgY2hhbmdlcyBpbiBmZXcgc3ViY2xhc3NlcyBvZiBD aXRyaXhSZXNvdXJjZUJhc2UuIEkgYW0gbm90IHRlc3RpbmcgdGhlIGNvbnN0YW50IHBlciBzZTsg SSBhbSB0ZXN0aW5nIGlmIGVhY2ggb25lIG9mIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0aGF0IG1l dGhvZCBpcyByZXR1cm5pbmcgd2hhdCBJIGV4cGVjdC4NCg0KSW4gb25lIGhhbmQsIEkgYWdyZWUg d2l0aCB5b3UgdGhhdCB0aGUgbWV0aG9kIGNvdWxkIGhhdmUgZG9jdW1lbnRhdGlvbi4gSSBqdXN0 IGhhdmUgbm90IGRvbmUgdGhhdCBiZWNhdXNlIEkgcmVhbGx5IGRvIG5vdCBrbm93IHdoYXQgdGhh dCBTdHJpbmcgdGhhdCB0aGUgbWV0aG9kIGlzIHJldHVybmluZyBpcy4gT24gdGhlIG90aGVyIGhh bmQsIGRvY3VtZW50YXRpb24gd2lsbCBub3Qgc2F2ZSB1cyBmcm9tIGZ1dHVyZSBidWdzLCBhcyBh IGNvbnNlcXVlbmNlIG9mIHNvbWUgY2hhbmdlIGluIHRob3NlIG1ldGhvZHMuIFRob3NlIHRlc3Rz IGNhbiBkbyB0aGF0IGF1dG9tYXRpY2FsbHkuDQoNCklmIHRoYXQgbWV0aG9kIGhhZCBhIGNvbmRp dGlvbmFsIHN0YXRlbWVudCBhbmQgaXQgd2FzIGNvZGVkIGludG8gQ2l0cml4UmVzb3VyY2VCYXNl IHdvdWxkIHlvdSB0aGluayBkaWZmZXJlbnQ/IFRoZSBwb2ludCBoZXJlIGlzIHRoYXQgb2JqZWN0 IG9yaWVudGF0aW9uIHJlbW92ZWQgdGhvc2UgaWZzLg0KDQpPbiBXZWQsIEF1ZyAxOSwgMjAxNSBh dCA3OjI2IEFNLCBEYWFuIEhvb2dsYW5kIDxkYWFuLmhvb2dsYW5kQGdtYWlsLmNvbTxtYWlsdG86 ZGFhbi5ob29nbGFuZEBnbWFpbC5jb20+PG1haWx0bzpkYWFuLmhvb2dsYW5kQGdtYWlsLmNvbT4+ IHdyb3RlOg0KYSB1bml0IGNhbiBiZSBkZWZpbmVkIGF0IG1vcmUgdGhlbiBqdXN0IHRoZSBtZXRo b2QgbGV2ZWwgYW5kIGluIHRoaXMgY2FzZQ0KdGhvc2UgcGF0aHMgaGF2ZSBjaGFuZ2VkIGZyb20g dW5kZXIgdXMgaW4gdGhlIHBhc3QuIEkgYW0gbm90IGp1c3RpZnlpbmcNCnRlc3RpbmcgYW55IGNv bnN0YW50IHRoaXMgd2F5LiBJIGFtIGp1c3RpZnlpbmcganVzdCB0aGlzIHdvcmsuDQoNCk9uIFdl ZCwgQXVnIDE5LCAyMDE1IGF0IDk6MDMgQU0sIEFuc2h1bCBHYW5nd2FyIDxhbnNodWwuZ2FuZ3dh ckBjaXRyaXguY29tPG1haWx0bzphbnNodWwuZ2FuZ3dhckBjaXRyaXguY29tPjxtYWlsdG86YW5z aHVsLmdhbmd3YXJAY2l0cml4LmNvbT4+DQp3cm90ZToNCg0KV2hhdCBJIG1lYW4gdG8gc2F5IGlz IHRoYXQgdW5pdCB0ZXN0IGFyZSBtZWFudCB0byB0ZXN0IGluZGl2aWR1YWwgdW5pdA0Kd2hpY2gg aGVyZSBpcyBnZXRQYXRjaEZpbGVQYXRoIGFuZCBub3QgbWVhbnQgdG8gdGVzdCBoaWVyYXJjaHkg YXMgeW91IGFyZQ0KcG9pbnRpbmcgb3V0IGhlcmUuIEJ5IGluZGl2aWR1YWwgdW5pdCBJIG1lYW4g aXQgZG9lc27igJl0IG1hdHRlciBmb3IgdGVzdA0KdGhhdCBpdCBpcyBpbiBjbGFzcyBBIG9yIGNs YXNzIEIuIFRoaXMgd2F5IHlvdSBhcmUga2luZCBvZiBqdXN0aWZ5aW5nIHRoYXQNCndlIHNob3Vs ZCB3cml0ZSB0ZXN0IGZvciBhbnkgY29uc3RhbnQgd2hpY2ggeW91IGhhdmUgZGVmaW5lZCBoYXMg dGhlIHZhbHVlDQp3aGljaCB5b3UgaGF2ZSBnaXZlbi4gQmVjYXVzZSBjb25zdGFudCB1bmRlciBk aWZmZXJlbnQgY2xhc3NlcyBjYW4gaGF2ZQ0KZGlmZmVyZW50IHZhbHVlcy4NCg0KQ2FuIHlvdSBw b2ludCB0byBhbnkgcmVmZXJlbmNlIHdoaWNoIGp1c3RpZmllcyB3cml0aW5nIHRlc3RzIGZvciB0 aGlzIGtpbmQNCm9mIHNjZW5hcmlvPw0KDQoNClJlZ2FyZHMsDQpBbnNodWwNCg0KT24gMTktQXVn LTIwMTUsIGF0IDExOjM0IGFtLCBEYWFuIEhvb2dsYW5kIDxkYWFuLmhvb2dsYW5kQGdtYWlsLmNv bTxtYWlsdG86ZGFhbi5ob29nbGFuZEBnbWFpbC5jb20+PG1haWx0bzpkYWFuLmhvb2dsYW5kQGdt YWlsLmNvbT4+DQp3cm90ZToNCg0KDQpPbiBXZWQsIEF1ZyAxOSwgMjAxNSBhdCA1OjU2IEFNLCBh bnNodWwxODg2IDxnaXRAZ2l0LmFwYWNoZS5vcmc8bWFpbHRvOmdpdEBnaXQuYXBhY2hlLm9yZz48 bWFpbHRvOmdpdEBnaXQuYXBhY2hlLm9yZz4+IHdyb3RlOg0KDQpJZiB0aGUgcHVycG9zZSBpcyB0 byBtYWtlIHN1cmUgdGhhdCBwYXRoIGlzIG5vdCBtb2RpZmllZCBieSBvdGhlcg0KZGV2ZWxvcGVy IHRoZW4gYWRkaW5nIG5vdGUvY29tbWVudCBvbiB0b3Agb2YgdGhhdCBsaW5lIG1ha2VzIG1vcmUg c2Vuc2UuDQpFdmVuIGFkZGluZyBub3RlIGlzIGtpbmQgb2YgaW1wbGljaXQgYXMgcGF0aHMgYXJl IGtpbmQgb2YgY29uc3RhbnRzIHdoaWNoDQphbnkgZGV2ZWxvcGVyIHdvdWxkIHRoaW5rIGJlZm9y ZSBjaGFuZ2luZy4gVGVzdHMgYXJlIG5vdCBtZWFudCBmb3IgdGhhdA0KcHVycG9zZS4NCg0KDQri gItBbnNodWwsIEkgaG9wZSBJIGRvbid0IHVuZGVyc3RhbmQgeW91IHdoZW4geW91IHNheSwgJ3Rl c3RzIGFyZSBub3QgbWVhbnQNCmZvciB0aGF0IHB1cG9zZScuIFdoZW4gdGhlIGhpZXJhcmNoeSBp cyBjaGFuZ2VkIGFuZCB0aGlzIGxlYWRzIHRvIHRoZQ0KY29uc3RhbnRzIHRvIGJlIHVzZWQgaW4g YSBkaWZmZXJlbnQgd2F5IGluIGRpZmZlcmVudCBjbGFzc2VzLCBhbiBlcnJvcg0Kb2NjdXJzIGR1 ZSB0byB0aGlzIHRoYXQgd2lsbCBiZSBjYXVnaHQgYnkgdGhlc2UgdGVzdHMuIFRoaXMgaXMgZXhh Y3RseSB3aGF0DQp1bml0IHRlc3RzIGFyZSBmb3Iu4oCLDQoNCmNsYXNzIEEgaGFzIGNvbnN0YW50 IHB0aD0iL3Jvb3QiLg0KY2xhc3MgQjpBIGhhcyBjb25zdGFudCBwdGg9Ii9yb290L2JsYSIuDQri gItjbGFzcyBDOkIgaGFzIG5vIGNvbnN0YW50IGhlbmNlIHB0aD0iL3Jvb3QvYmxhIi4NCg0Kbm93 IEMgaXMgY2hhbmdlZCB0byBDOkEgYW5kIGl0cyBwdGggaXMgdGhlcmUgZm9yZSBjaGFuZ2VkIHRv ICIvcm9vdCIu4oCLDQpUaGlzIGlzIHVuaW50ZWRlZCBhbmQgYSBtaXN0YWtlIHRoYXQgd2lsbCBi ZSBjYXVnaHQgYnkgc3VjaCB0ZXN0cy4NCg0KDQoNCi0tDQpEYWFuDQoNCg0KDQoNCg0KLS0NCkRh YW4NCg0KDQoNCi0tDQpSYWZhZWwgV2VpbmfDpHJ0bmVyDQoNCg0K --_000_07661B5635144CF0A5057C06F99E6811citrixcom_--