Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: [DISCUSS] Improving community experience for (new) contributors
From: Sebastien Goasguen <runseb@gmail.com>
In-Reply-To: 
 <CANLSSBUnNScMjDwSRY_CMYU1PambgK=tWxkDb1Dhm42g24p4tQ@mail.gmail.com>
Date: Wed, 26 Aug 2015 12:35:28 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <074C0F84-B2DA-4A77-BCB1-1AED11E9411D@gmail.com>
References: 
 <CANLSSBUnNScMjDwSRY_CMYU1PambgK=tWxkDb1Dhm42g24p4tQ@mail.gmail.com>
To: dev@cloudstack.apache.org


> On Aug 26, 2015, at 12:20 PM, Rohit Yadav <bhaisaab@apache.org> wrote:
>=20
> Hi all,
>=20
> I=E2=80=99ve identified few issues around the recent changes that I =
don=E2=80=99t know
> how we can fix or improve but I hope to get feedback from the
> community.
>=20
> I understand that you may disagree with what I=E2=80=99m sharing which =
is
> alright, even in your disagreement I hope that you don=E2=80=99t take =
an
> offence on that, that is certainly not my aim. I personally want to
> the community to be felt welcoming so that we can attract and retain
> new contributors and have a nice environment for everyone.
>=20
> Some observations and comments:
>=20
> - Generally those of us who have worked for long in the community or
> have colleagues from dayjob working in the ACS community - we have
> better chances in getting their PRs merged; for new contributors this
> pattern is not encouraging and certainly not welcoming if their PRs
> get closed.
>=20
> - The recent drive to use Github PRs seems to be really working great
> for us, but still the requirements of at least 2 +1s/LGTM, unit tests
> and pedantic bike-shedding has cost us new developers/contributors and
> kills the joy of programming for some; for experienced and
> commercially backed developers this makes sense. I personally try to
> be pragmatic and lenient on code reviews as long as smoke tests
> (Travis) pass.
>=20
> - Contributions are process-oriented that cost time and effort; there
> have been initiative to satisfy the tool but not the human, and not
> optimizing on developer time.
>=20
> - What should we do to get more developer contributors and how to
> attract hobbyists or casual contributors.
>=20

Rohit, that=E2=80=99s a very valid point.

Personally, I don=E2=80=99t think we should close PRs that may be valid =
but just not ripe for a release.

Your recent comment on Rafael PR about embedded jetty for instance is a =
good example. I can=E2=80=99t review this, and since I don=E2=80=99t run =
CloudStack in prod I don=E2=80=99t want to force things that operators =
may not want or may not be ready yet. So this PR got stuck waiting for =
Pierre-Yves who talked about it.
Did this slow down Rafael contribution I don=E2=80=99t know, we should =
ask him.

Maybe we could merge that type of things, just not in master.

Can you point us to other PR that you saw that made you write this note. =
We could all have a look.


> Regards.