cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...
Date Sat, 29 Aug 2015 22:03:36 GMT
GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/761

    Have HyperV behave in 4.4 and return null instead of false

    Commit 6a4927f660f776bcbd12ae45f4e63ae2c2e96774 made the HyperV investigator return false
instead of null.
    
    Returning false means the VM is NOT running, returning null means "I don't know". In 4.4
I experienced corruption because of HyperV returning false, instead of null.
    
    Tonight I experienced corruption when one of our management servers went down (out-of-memory,
not root caused yet). While all hypervisors that were connected to this management server
were connecting the other, HA work started as well with investigators. HyperV happily reported
everything as down (while it was still running), causing a mess.
    
    In 4.5 and master this was already fixed. If you know a better way to fix this, please
let me know!
    This may cause another FindBugs alert, not sure how to resolve that. I just want this
out ASAP. Maybe @DaanHoogland @wilderrodrigues or @miguelaferreira can advise on how to fix
this properly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack fix-hyperv-returns

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #761
    
----
commit 8ed40414992cdcd53dd2a241cf34010c15c1d471
Author: Remi Bergsma <github@remi.nl>
Date:   2015-08-29T21:58:00Z

    Have HyperV behave in 4.4 and return null instead of false
    
    Commit 6a4927f660f776bcbd12ae45f4e63ae2c2e96774 made the HyperV investigator return false
insteads of null.
    
    Returning false means the VM is NOT running, returning null means "I don't know". In 4.4
I experienced corruption because of HyperV returning false, instead of null.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message