cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removing unit test that was failing to co...
Date Wed, 26 Aug 2015 18:30:23 GMT
GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/747

    Removing unit test that was failing to cover the resolution of the nano time

       - The difference between 2 consecutive calls to System.nanoTime() returns a resolution
that depends on the OS implementation. Due to that, the test was failing in an intermittent
manner.
       - Today we decided to remove the test since it was not testing a direct feature of
ACS
    
    I did not create an issue on Jira because it's only about removing an unit test. There
is no bug fix involved or feature developed.
    
    @miguelaferreira @remibergsma @bhaisaab @DaanHoogland 
    
    Could you have a look at this change, please?
    
    Cheers,
    Wilder

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schubergphilis/cloudstack fix/broken_profiler_unit_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #747
    
----
commit d74d134698ce381b5d18d6c71815f5042ffd1816
Author: wilderrodrigues <wrodrigues@schubergphilis.com>
Date:   2015-08-26T17:25:47Z

    Removing unit test that was covering the resolution of the nano time
    
       - The difference between 2 consecultive calls to System.nanoTime() returns a resolution
that depends on the OS implementation. Due to that, the test was failing in an inttermmitent
manner
       - Today we decided to remove the test since it was not testing a direct feature of
ACS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message