cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ustcweizhou <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-5863: revert volume snapshot f...
Date Mon, 24 Aug 2015 09:11:45 GMT
GitHub user ustcweizhou opened a pull request:

    https://github.com/apache/cloudstack/pull/732

    CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2

    Guys, can you review it? things need to be discussed:
    (1) this supports KVM/QCOW2 only. Anyone want to implement for other Hypervisor/format
?
    (2) The original data volume (on primary storage) will be removed.
    (3) The script uses the default timeout in libvirtComputingResource. Do we need to add
one in global configuration (like copy.volume.wait or backup.snapshot.wait, create.volume.from.snapshot.wait)
    (4) In scripts/storage/qcow2/managesnapshot.sh, I use "qemu-img convert -f qcow2 -O qcow2"
to copy the snapshot from secondary to primary (hence there is no base image file), instead
of "cp -f", this is because convert is faster than cp in my testing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ustcweizhou/cloudstack revert-volume-snapshot-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #732
    
----
commit 92344c006dfa8abf4ce81e2a25839cbb762d1b17
Author: Wei Zhou <w.zhou@tech.leaseweb.com>
Date:   2015-08-24T09:01:50Z

    CLOUDSTACK-5863: revert volume snapshot for KVM/QCOW2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message