cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From insom <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Default to notify only script to handle n...
Date Fri, 14 Aug 2015 11:25:36 GMT
GitHub user insom opened a pull request:

    https://github.com/apache/cloudstack/pull/696

    Default to notify only script to handle non-CLVM/QCOW cases.

    This relates to [CLOUDSTACK-8732](https://issues.apache.org/jira/browse/CLOUDSTACK-8732)
    
    Before this commit the call to `getResizeScriptType` would throw an exception (earlier
versions returned `null`, which was fine) - this caused the RBD case to fail. By changing
the default to notify only we fix the case for any non-CLVM and non-QCOW cases, too.
    
    This is RBD for now, but this should extend to new storage types supported by Libvirt
natively in future.
    
    This is my first attempted contribution: I can see a case for adding RBD logic to the
actual getResizeScriptType call, too, but I felt that putting it `LibvirtResizeVolumeCommandWrapper.java`
kept the special-casing of RBD (and comments about that) in one place.
    
    ### Caveat:
    
    With Libvirt 1.2.2 this actually doesn't do the right thing - but it does do what the
documentation *says* should be the right thing, so I'm going to test if this is a Libvirt
bug which is fixed in a later version.
    
    (To make it work I need to execute something like:
    
        virsh blockresize --path vda --size 100G i-7-44-VM
    
    where vda is the path as far as the *guest* is concerned, and not an `rbd/` path - which
*should* work, but doesn't.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iwebhosting/cloudstack rbd-live-resize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #696
    
----
commit 77a96ed1f77627aa7c528b5b9f822b31ec1868a0
Author: Aaron Brady <aaron@iweb.co.uk>
Date:   2015-08-14T11:15:07Z

    Default to notify only script to handle non-CLVM/QCOW cases.
    
    Before this commit the call to `getResizeScriptType` would throw
    an exception (earlier versions returned `null`, which was fine) -
    this caused the RBD case to fail. By changing the default to
    notify only we fix the case for any non-CLVM and non-QCOW cases.
    
    This is RBD for now, but this should extend to new storage
    types suppored by Libvirt natively in future.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message