cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Date Mon, 31 Aug 2015 08:01:43 GMT
I agree

On Mon, Aug 31, 2015 at 6:45 AM, kansal <git@git.apache.org> wrote:

> Github user kansal commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/685#issuecomment-136250704
>
>     @DaanHoogland Yes the first test in a way does the same thing only.
> The thing is that the second test is more intuitive in a way that it firsts
> registers a key-pair (the registration is successful) and then registers
> another one with different name but same key (Registration fails here). So
> the "Existing pair" check which the first one wants to test is
> automatically tested. In my opinion the first test can be removed. Your
> opinion?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message