cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Tutkowski <mike.tutkow...@solidfire.com>
Subject Re: [GitHub] cloudstack pull request: getUsedBytes should query the SolidFire c...
Date Thu, 13 Aug 2015 04:59:34 GMT
I'm not sure what the protocol is on this, so I just went ahead and checked
in the code to fix the FindBugs issue and noted the PR (674) it is related
to.

Here is the commit:

8fcc76e

On Wed, Aug 12, 2015 at 10:55 PM, Mike Tutkowski <
mike.tutkowski@solidfire.com> wrote:

> Oh, I read what you wrote wrong. OK - thanks.
>
> On Wed, Aug 12, 2015 at 10:54 PM, mike-tutkowski <git@git.apache.org>
> wrote:
>
>> Github user mike-tutkowski commented on the pull request:
>>
>>     https://github.com/apache/cloudstack/pull/674#issuecomment-130535316
>>
>>     OK, but - ultimately - I do want to convert it to a primitive long.
>>
>>     On Wed, Aug 12, 2015 at 10:50 PM, Rajani Karuturi <
>> notifications@github.com>
>>     wrote:
>>
>>     > valueOf returns a new Long() where as parseLong returns primitive
>> long.
>>     > valueOf causes unboxing as what is required is a primitive long.
>> Using
>>     > parseLong will satisfy findbugs I think.
>>     >
>>     > —
>>     > Reply to this email directly or view it on GitHub
>>     > <
>> https://github.com/apache/cloudstack/pull/674#issuecomment-130535022>.
>>     >
>>
>>
>>
>>     --
>>     *Mike Tutkowski*
>>     *Senior CloudStack Developer, SolidFire Inc.*
>>     e: mike.tutkowski@solidfire.com
>>     o: 303.746.7302
>>     Advancing the way the world uses the cloud
>>     <http://solidfire.com/solution/overview/?video=play>*™*
>>
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkowski@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> <http://solidfire.com/solution/overview/?video=play>*™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message