cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafaelweingartner <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Changed variable s_logger to non-static a...
Date Mon, 31 Aug 2015 13:07:25 GMT
Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/714#issuecomment-136366153
  
    Hi @karuturi, If you take a look at here: 
    https://github.com/rafaelweingartner/cloudstack/blob/master-lrg-cs-hackday-003/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
    You can see that the commit was properly coded. The method “resolveNameInGuid” was
static (for some off reason) and we had changed it to non-static, it does not need to be static.
It seems that there was either a problem with the merge or someone else had put back the static
keyword in that method there.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message