cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack:8647 LDAP Trust AD and Autoimp...
Date Mon, 31 Aug 2015 11:37:04 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/755#discussion_r38303804
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
    @@ -243,4 +263,22 @@ public boolean isLdapEnabled() {
                 closeContext(context);
             }
         }
    +
    +    @Override
    +    public LinkDomainToLdapResponse linkDomainToLdap(Long domainId, String type, String
name, short accountType) {
    +        Validate.notNull(type, "type cannot be null. It should either be GROUP or OU");
    +        Validate.notNull(domainId, "domainId cannot be null.");
    +        Validate.notEmpty(name, "GROUP or OU name cannot be empty");
    +        //Account type constants in com.cloud.user.Account
    +        Validate.isTrue(accountType>=0 && accountType<=5, "accountype should
be a number from 0-5");
    --- End diff --
    
    The parameter description in the Cmd says allowed values are 0, 1, 2. Shouldn't this be
in sync with description?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message