cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Have HyperV behave in 4.4 and return null...
Date Sun, 30 Aug 2015 08:49:47 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/761#issuecomment-136099464
  
    @miguelaferreira Thanks. I guess returning `null` is done in many of the Investigators
right now, but would be great to improve it. If we at least could make it the same in 4.4
like in master that'd be great because that works (https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/hyperv/src/com/cloud/ha/HypervInvestigator.java)
and that throws `throw new UnknownVM();`
    
    The `OVM3` Investigator also seems smarter (https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/ovm3/src/main/java/com/cloud/ha/Ovm3Investigator.java).
    
    I could live with a quick hotfix for `4.4` that I can deploy soon, and then improving
this whole thing in `master`. Not sure what is possible right now. We'll discuss tomorrow
:-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message