cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Date Fri, 28 Aug 2015 11:59:30 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/685#discussion_r38192659
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -354,6 +354,10 @@ CREATE VIEW `cloud`.`user_vm_view` AS
                left join
             `cloud`.`user_vm_details` `custom_ram_size`  ON (((`custom_ram_size`.`vm_id`
= `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory')));
     
    +---Additional checks to ensure duplicate keys are not registered and remove the previously
stored duplicate keys.
    +DELETE `s1` FROM `ssh_keypairs` `s1`, `ssh_keypairs` `s2` WHERE `s1`.`id` > `s2`.`id`
AND `s1`.`public_key` = `s2`.`public_key` AND `s1`.`account_id` = `s2`.`account_id`;
    +ALTER TABLE `ssh_keypairs` ADD UNIQUE `unique_index`(`fingerprint`,`account_id`);
    --- End diff --
    
    May be name unique_index can be better renamed? By default UNIQUE constraint signifies
that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message