cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8762: Check to confirm disk ac...
Date Fri, 28 Aug 2015 09:24:52 GMT
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/754#issuecomment-135709691
  
    @wido just checked again, most debug messages are in loop and changing them to info or
errors would be unnecessary. In case of error, run time exceptions are thrown that would be
captured in the logs and won't allow VMs to start.
    
    @miguelaferreira I discussed the issue of changing logic there, it seems that the mtime
should be reliable enough and I won't be adding md5 or other checksum checking logic as that
will be too slow and costing on CPU and IO. Do you still want me to refactor the logic as
a separate class or move to say FileUtil in the cloud-utils package?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message