cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...
Date Wed, 26 Aug 2015 09:59:58 GMT
Github user anshul1886 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/673#discussion_r37964980
  
    --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
    @@ -2188,7 +2188,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
             }
     
             if (details != null && !details.isEmpty()) {
    -            vmInstance.setDetails(details);
    +            _vmDao.loadDetails(vmInstance);
    --- End diff --
    
    When do we need to remove detail? Even if needed then those values can be updated to get
the desired effect. Many details are for internal purposes only and user is not even aware
of them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message