cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8761: Replace some profiler.ge...
Date Wed, 26 Aug 2015 05:24:20 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/730#issuecomment-134834411
  
    @ustcweizhou is just calling the wrapper for the system in millis, which was added to
the profiler. For the remaining cases, the nano time will be used (getDuration()).
    
    His use of getDurationInMillis() looks good because inside the method I convert the nanoseconds
to milliseconds:
    
    (stopTickNanoSeconds - startTickNanoSeconds) / (long)Math.pow(MILLIS_FACTOR, EXPONENT);
    
    LGTM :+1: 
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message