cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Replace some profiler.getDuration with pr...
Date Mon, 24 Aug 2015 05:41:22 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/730#issuecomment-134047200
  
    The changes look good to me :+1: from my end.
    But, I would like @wilderrodrigues to review this as the profiler was refactored by him
in commit 5557ad55880f981c2621a4f411b80e4301469104 (the behavior of getDuration hasnt changed
in the refactoring but want to double check)
    
    @ustcweizhou, looks like clustered management server behavior would be affected due to
this as the interpretation of config value `cluster.heartbeat.interval` has changed from ns
to ms. Can you please log a defect with the actual issue and link it here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message