cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8754: VM migration triggered b...
Date Fri, 21 Aug 2015 14:52:51 GMT
Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/725#issuecomment-133451646
  
    @DaanHoogland check the base class
    The test cannot catch a new addition to the class which may break serialization.
    Suppose a new non-serializable member of type Object is added to the class and is initialized
to null and only way to set it is through a new ctor or setter. Then the test would still
pass. Ideally in this case you want the test to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message