cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix for the NicVO.java regression.
Date Fri, 21 Aug 2015 12:20:58 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/726#issuecomment-133406706
  
    LGTM. lets wait for travis and other jenkins verifications.
    
    In future, can you club all refactoring work in a branch and merge them together? That
way, we can test it once(giving bigger time window for everyone to verofy) and merge
    Also, I think this refactoring is a candidate for 4.7. We are already close to RC on 4.6(once
4.5.2 is done) and cannot afford regressions at this stage.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message