cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Date Wed, 19 Aug 2015 03:56:20 GMT
Github user anshul1886 commented on the pull request:

    https://github.com/apache/cloudstack/pull/700#issuecomment-132438972
  
    @rafaelweingartner  @DaanHoogland If the purpose is to make sure that path is not modified
by other developer then adding note/comment on top of that line makes more sense. Even adding
note is kind of implicit as paths are kind of constants which any developer would think before
changing. Tests are not meant for that purpose. 
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message