cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Date Tue, 18 Aug 2015 11:39:38 GMT
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/700#issuecomment-132182774
  
    @anshul1886 if the purpose is to ensure that the path returned doesn't change, this seems
perfectly aceptable to me. If people want to change the path in the future they must be aware
and change the unit tests as well. That said they seem a litle trivial but I'm alright with
that. It is mainly the integrity class hierarchy of the resources that is being tested this
way.
    (comment moved to this PR where it makes less non-sense)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message