cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anshul1886 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Date Tue, 18 Aug 2015 04:12:16 GMT
Github user anshul1886 commented on the pull request:

    https://github.com/apache/cloudstack/pull/700#issuecomment-132067886
  
    @cristofolini @DaanHoogland Are these unit tests adding any value? What type of value
are they adding here? To me these seems to be burden on maintainer or developer who is going
to touch this code in future. 
    
    if somebody in future wants to change path then only he will change the method and this
unit test will fail which will make him to change according to his requirements. In that scenario
purpose of tests is altogether lost. Unit tests I believe are not meant to be modified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message