cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Removed duplicate code in CitrixResourceB...
Date Mon, 17 Aug 2015 15:14:30 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/700#discussion_r37198057
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpServerResource.java
---
    @@ -38,20 +32,12 @@
     
         private final static Logger s_logger = Logger.getLogger(XcpServerResource.class);
         private final static long mem_32m = 33554432L;
    -
    +    
         @Override
    -    protected List<File> getPatchFiles() {
    -        final List<File> files = new ArrayList<File>();
    -        final String patch = "scripts/vm/hypervisor/xenserver/xcpserver/patch";
    -        final String patchfilePath = Script.findScript("", patch);
    -        if (patchfilePath == null) {
    -            throw new CloudRuntimeException("Unable to find patch file " + patch);
    -        }
    -        final File file = new File(patchfilePath);
    -        files.add(file);
    -        return files;
    +    protected String getPatchFilePath() {
    +        return "scripts/vm/hypervisor/xenserver/xcpserver/patch";
         }
    -
    +    
    --- End diff --
    
    "trailing whitespace"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message