cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...
Date Mon, 17 Aug 2015 12:45:41 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/673#discussion_r37183568
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ---
    @@ -136,13 +136,13 @@ public String getInstanceName() {
             return instanceName;
         }
     
    -    public Map getDetails() {
    +    public Map<String, String> getDetails() {
    --- End diff --
    
    The CommandType.MAP API args are usually map of object returning objects; in practice
AFAIR all map args are string->string. Either way, I don't understand this change in getDetails(),
this at least will result in returning a new Map, so likely the author wants their details
to be sort of read-only? If so, why not use final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message