cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: This branch implements the CSV and native...
Date Mon, 17 Aug 2015 10:16:51 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/351#discussion_r37174252
  
    --- Diff: plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
---
    @@ -978,14 +1025,58 @@ public JContainer ModifyStoragePoolCommand([FromBody]dynamic cmd)
                         else if (poolType == StoragePoolType.NetworkFilesystem ||
                             poolType == StoragePoolType.SMB)
                         {
    -                        NFSTO share = new NFSTO();
    -                        String uriStr = "cifs://" + (string)cmd.pool.host + (string)cmd.pool.path;
    -                        share.uri = new Uri(uriStr);
    -                        hostPath = Utils.NormalizePath(share.UncPath);
    +                        if ((bool)cmd.add)
    --- End diff --
    
    this ethod is getting very big. extracting some of the code to a private method would
make it more readable (and probably more maintainable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message