cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Interface changes related to CLOUDSTACK-8...
Date Fri, 14 Aug 2015 09:06:32 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/680#discussion_r37060382
  
    --- Diff: server/src/com/cloud/server/ManagementServerImpl.java ---
    @@ -3378,6 +3379,10 @@ private String signRequest(final String request, final String key)
{
             final Integer apiLimitInterval = Integer.valueOf(_configDao.getValue(Config.ApiLimitInterval.key()));
             final Integer apiLimitMax = Integer.valueOf(_configDao.getValue(Config.ApiLimitMax.key()));
     
    +        // Check if users can view destroyed vm's, expunge and/or recover them. Admins
can always do so.
    --- End diff --
    
    not really a comment that enlightens us beyond the naming of the variables, so could be
omitted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message