cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jayapal <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix site-to-site VPN feature
Date Fri, 14 Aug 2015 08:37:50 GMT
Github user jayapal commented on the pull request:

    https://github.com/apache/cloudstack/pull/693#issuecomment-131026551
  
    Guys wrong tag.
    
    Myuser name is jayapal and actual commiter was jayapalu
    
    On Fri, Aug 14, 2015 at 1:47 PM, Remi Bergsma <notifications@github.com>
    wrote:
    
    > This is work done together with @Jayapal <https://github.com/Jayapal> on
    > fixing the site2site VPN. The first part was done in PR #690
    > <https://github.com/apache/cloudstack/pull/690> by @Jayapal
    > <https://github.com/Jayapal>. On top of that, some other fixes were
    > needed and those are added in this PR. It made sense to make a new PR which
    > includes all fixes so we can actually test it.
    >
    > The original PR #690 <https://github.com/apache/cloudstack/pull/690> is
    > already merged into this one, so can be closed. Since the commit ids are
    > kept the same, merging this will close both.
    >
    > I closely compared the 4.4/4.5 implementation with the new 4.6 one. I did
    > not only make it work, but also added some security improvements (some of
    > which were also in 4.4/4.5). I noticed the pre shared key was being logged,
    > so removed that as well.
    >
    > This is how I tested and verified it:
    >
    > https://github.com/schubergphilis/MCT-shared/tree/master/helper_scripts/cloudstack/vpn_tests
    > When I have some time available, I'll write a Marvin test for it that we
    > can include in the repo.
    >
    > It now works(tm) with one manual step due to CLOUDSTACK-8685:
    > We need a default gateway before site-to-site VPN will actually work. It
    > will connect, but not forward packets. The reason for this, is due to the
    > iptables setup. VM1 has router1 as gateway, but router1 does not know the
    > route to VM2 so it will give up. With a default gateway, the packets are
    > about to be forwarded to the default gateway but when they reach eth1 the
    > public nic, iptables kicks in, does some magic and forwards it through the
    > ipsec tunnel. So, you need a default gw set to upstream.
    >
    > Workaround for now is setting the route manually:
    > route add default gw 1.2.3.4 or ip route add default via 1.2.3.4
    >
    > In other words, we need to fix CLOUDSTACK-8685 soon, too.
    >
    > @Jayapal <https://github.com/Jayapal> @snuf <https://github.com/snuf>
    > could you please review this?
    > ------------------------------
    > You can view, comment on, or merge this pull request online at:
    >
    >   https://github.com/apache/cloudstack/pull/693
    > Commit Summary
    >
    >    - CLOUDSTACK-8710: Fixed applying iptables rules for s2s vpn
    >    - CLOUDSTACK-8730: fix s2s iptables rules and ipsec config
    >    - tighten security of site-to-site VPN
    >    - do not log sensitive site-to-site VPN PSK
    >    - Merge pull request #690 from jayapalu/vpn
    >
    > File Changes
    >
    >    - *M* systemvm/patches/debian/config/opt/cloud/bin/configure.py
    >    <https://github.com/apache/cloudstack/pull/693/files#diff-0> (18)
    >    - *M* systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py
    >    <https://github.com/apache/cloudstack/pull/693/files#diff-1> (5)
    >
    > Patch Links:
    >
    >    - https://github.com/apache/cloudstack/pull/693.patch
    >    - https://github.com/apache/cloudstack/pull/693.diff
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/693>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message