cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8727: API call listVirtualMach...
Date Wed, 12 Aug 2015 12:51:01 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/685#discussion_r36855234
  
    --- Diff: setup/db/db/schema-452to460.sql ---
    @@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
             `cloud`.`user_vm_details` `custom_speed`  ON (((`custom_speed`.`vm_id` = `cloud`.`vm_instance`.`id`)
and (`custom_speed`.`name` = 'CpuSpeed')))
                left join
             `cloud`.`user_vm_details` `custom_ram_size`  ON (((`custom_ram_size`.`vm_id`
= `cloud`.`vm_instance`.`id`) and (`custom_ram_size`.`name` = 'memory')));
    +        delete s1 from ssh_keypairs s1, ssh_keypairs s2 where s1.id > s2.id and s1.public_key
= s2.public_key;
    --- End diff --
    
    I believe, its an api change required rather adding the constraint at the db level, otherwise
it will mask the actual issue in the code where these duplicates are getting added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message