cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Date Wed, 12 Aug 2015 07:13:31 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/669#discussion_r36832023
  
    --- Diff: client/pom.xml ---
    @@ -478,6 +478,12 @@
                     <copy todir="${basedir}/target/generated-webapp/WEB-INF/classes/scripts">
                       <fileset dir="${basedir}/../scripts"/>
                     </copy>
    +                <copy todir="${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js">
    --- End diff --
    
    Do we have any unit-tests added for this change? As well, if we possible, can we have
a document for the console proxy workflow available on wiki ? This may help people to know
the exact workflow or class interactions with business flow.  
    
    As well, a small change to this request message "Made the adding new keyboard language
support easier" could be beneficial i believe, helps people to know the complete context for
this change. 
    
    Note :this is not specific to this line, but a generic note. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message