cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remibergsma <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8721: Fixed Setting details of...
Date Tue, 11 Aug 2015 15:16:32 GMT
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/673#issuecomment-129925883
  
    @anshul1886 Tested your code, works just fine! LGTM.
    
    The only thing I noticed: excisting key/values are removed, then added again. So the net
result is OK. It just inserts them again (the auto-increment goes up) but that wasn't introduced
by your code as far as I can see.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message