cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Date Tue, 11 Aug 2015 02:05:21 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/669#discussion_r36705867
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
    @@ -0,0 +1,59 @@
    +/*
    + *   Licensed to the Apache Software Foundation (ASF) under one
    + *   or more contributor license agreements.  See the NOTICE file
    + *   distributed with this work for additional information
    + *   regarding copyright ownership.  The ASF licenses this file
    + *   to you under the Apache License, Version 2.0 (the
    + *   "License"); you may not use this file except in compliance
    + *   with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing,
    + *   software distributed under the License is distributed on an
    + *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + *   KIND, either express or implied.  See the License for the
    + *   specific language governing permissions and limitations
    + *   under the License.
    + */
    +
    +package com.cloud.hypervisor.kvm.resource.wrapper;
    +
    +import com.cloud.agent.api.Answer;
    +import com.cloud.agent.api.CopyFileInVmAnswer;
    +import com.cloud.agent.api.CopyFileInVmCommand;
    +import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
    +import com.cloud.resource.CommandWrapper;
    +import com.cloud.resource.ResourceWrapper;
    +import com.cloud.utils.ssh.SshHelper;
    +import org.apache.commons.io.FileUtils;
    +import org.apache.commons.io.filefilter.TrueFileFilter;
    +import org.apache.log4j.Logger;
    +
    +import java.io.File;
    +
    +@ResourceWrapper(handles = CopyFileInVmCommand.class)
    +public class LibvirtCopyFileInVmCommandWrapper   extends CommandWrapper<CopyFileInVmCommand,
Answer, LibvirtComputingResource> {
    +
    +    private static final Logger s_logger = Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
    +
    +    @Override public Answer execute(CopyFileInVmCommand cmd, LibvirtComputingResource
libvirtComputingResource) {
    +        final File keyFile = new File("/root/.ssh/id_rsa.cloud");
    +        try {
    +            File file = new File(cmd.getSrc());
    +            if(file.exists()) {
    +                if(file.isDirectory()) {
    +                    for (File f : FileUtils.listFiles(new File(cmd.getSrc()), TrueFileFilter.INSTANCE,
TrueFileFilter.INSTANCE)) {
    +                        SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, null, cmd.getDest(),
f.getCanonicalPath(), null);
    +                    }
    +                } else {
    --- End diff --
    
    My note was related to the below example.
    example_dir_for_iteration contains say 5 entries as follows (dira, text_file_a,socket_file_a,block_device_file_a,zip_file_a),
in else block of the code, we are copying all files. Now, in your case where you explicitly
mentioned key file path(/root/..) these file types may not be possible,  but these type  of
copying without file types checks, leads to vulnerabilities in the application long run. So,
i mentioned to see we are copying files as mentioned in else block, do we want to add some
file type check that we are interesting in copying, for that i gave an example where directory
contains multiple file types.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message