cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Date Tue, 11 Aug 2015 01:50:22 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/669#discussion_r36705202
  
    --- Diff: plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
    @@ -595,6 +597,25 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
             }
         }
     
    +    private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
    +        File keyFile = getSystemVMKeyFile();
    +        try {
    +            File file = new File(cmd.getSrc());
    +            if(file.exists()) {
    +                if(file.isDirectory()) {
    +                    for (File f : FileUtils.listFiles(new File(cmd.getSrc()), TrueFileFilter.INSTANCE,
TrueFileFilter.INSTANCE)) {
    +                        SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, null, cmd.getDest(),
f.getCanonicalPath(), null);
    +                    }
    +                } else {
    +                    SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, null, cmd.getDest(),
file.getCanonicalPath(), null);
    +                }
    +            }
    +        } catch (Exception e) {
    +            s_logger.error("Fail to copy file " + cmd.getSrc() + " in VM " + cmd.getVmIp(),
e);
    +            return new CopyFileInVmAnswer(cmd, e);
    +        }
    +        return new CopyFileInVmAnswer(cmd);
    --- End diff --
    
    Its not a big issue as such, but iam seeing like if there is an exception at liine 617:
 "return new CopyFileIn.. (cmd)", then catch will still throw your new object created. Again,
its not a great issue to be worry about!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message