cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sedukull <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Made the adding new keyboard language sup...
Date Tue, 11 Aug 2015 01:46:49 GMT
Github user sedukull commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/669#discussion_r36705033
  
    --- Diff: systemvm/js/ajaxviewer.js ---
    @@ -184,7 +205,7 @@ KeyboardMapper.prototype = {
     			if(eventType == AjaxViewer.KEY_UP && (code == AjaxViewer.JS_KEY_ALT || code
== AjaxViewer.JS_KEY_CTRL))
     				this.mappedInput.push({type : eventType, code: this.jsX11KeysymMap[code], modifiers:
modifiers});
     			
    -		} else if(eventType == AjaxViewer.KEY_PRESS && guestos == 'null') {
    +		} else if(eventType == AjaxViewer.KEY_PRESS && guestos.toLowerCase() != 'windows')
{
    --- End diff --
    
    This might be existing code, but for more cleaner way, do we want to remote all os strings
and make them as constants or sort of enums defined at one place and use them with reference
here? 
    something like:
    gustos.toLowerCase() != OsTypes.WINDOWS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message