cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...
Date Mon, 10 Aug 2015 09:27:15 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/635#discussion_r36613344
  
    --- Diff: api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
---
    @@ -60,6 +61,15 @@
                    description = "template ID of the template to be prepared in primary storage(s).")
         private Long templateId;
     
    +    @ACL(accessType = AccessType.OperateEntry)
    +    @Parameter(name = ApiConstants.STORAGE_ID,
    +            type = CommandType.UUID,
    +            entityType = StoragePoolResponse.class,
    +            required = false,
    +            description = "storage pool ID of the primary storage pool to which the template
should be prepared. If it is not provided the template" +
    +                    " is prepared on all the available primary storage pools.")
    +    private Long storageId;
    --- End diff --
    
    @remibergsma, @kishankavala is concurring with the observation by @devdeep that his call
was good in the name of consistency. I think he was being unconditional about his LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message