cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8709 No out of band migrate al...
Date Sat, 08 Aug 2015 09:19:44 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/666#discussion_r36576679
  
    --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
---
    @@ -2627,7 +2627,7 @@ public boolean postStateTransitionEvent(final StateMachine2.Transition<State,
Vi
                     s_logger.info("Schedule a router reboot task as router " + vo.getId()
+ " is powered-on out-of-band. we need to reboot to refresh network rules");
    --- End diff --
    
    @koushik-das The problem is probably not solved in the most elegant way. The bit (vo.getType()
== VirtualMachine.Type.DomainRouter) could have been pulled up in an extra containing if block.
    In the end the only the reprovision_out_of_band is making the final choice between alerting
and rebooting


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message