cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kishankavala <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...
Date Thu, 06 Aug 2015 05:18:29 GMT
Github user kishankavala commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/656#discussion_r36381969
  
    --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
    @@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO host, boolean
investigate)
     
             // send an email alert that the host is down
             StringBuilder sb = null;
    +        List<VMInstanceVO> reorderedVMList = new ArrayList<VMInstanceVO>();
             if ((vms != null) && !vms.isEmpty()) {
                 sb = new StringBuilder();
    -            sb.append("  Starting HA on the following VMs: ");
    +            sb.append("  Starting HA on the following VMs:");
                 // collect list of vm names for the alert email
    -            VMInstanceVO vm = vms.get(0);
    -            if (vm.isHaEnabled()) {
    -                sb.append(" " + vm);
    -            }
    -            for (int i = 1; i < vms.size(); i++) {
    -                vm = vms.get(i);
    +            for (int i = 0; i < vms.size(); i++) {
    +                VMInstanceVO vm = vms.get(i);
    +                String name = vm.getInstanceName();
    +                if (name.startsWith("i-")) {
    --- End diff --
    
    @koushik-das To identify VRs in this list, vm.getType().equals(VirtualMachine.Type.DomainRouter)
would be better, instead of relying on the Vm name. Also, in the mentioned code SSVM and CPVM
get higher priority than UserVms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message