cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Reduce the lowest hypervisor snapshot res...
Date Tue, 04 Aug 2015 04:03:48 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/653#discussion_r36155878
  
    --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java
---
    @@ -352,8 +352,8 @@ public long getVolumeSizeIncludingHypervisorSnapshotReserve(Volume
volume, Stora
             Integer hypervisorSnapshotReserve = volume.getHypervisorSnapshotReserve();
     
             if (hypervisorSnapshotReserve != null) {
    -            if (hypervisorSnapshotReserve < 50) {
    -                hypervisorSnapshotReserve = 50;
    +            if (hypervisorSnapshotReserve < 10) {
    +                hypervisorSnapshotReserve = 10;
    --- End diff --
    
    Why not use Math.max(hypervisorSnapshotReserve, 10)? That way we will be using the const
only once and its more readable( to me ;) )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message