cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mike-tutkowski <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack 8656: do away with more silent...
Date Mon, 03 Aug 2015 22:56:33 GMT
Github user mike-tutkowski commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/654#discussion_r36141156
  
    --- Diff: framework/db/src/com/cloud/utils/db/DbUtil.java ---
    @@ -43,8 +43,10 @@
     
     import org.apache.log4j.Logger;
     
    +import static com.cloud.utils.AutoCloseableUtil.closeAutoCloseable;
    +
     public class DbUtil {
    -    protected final static Logger s_logger = Logger.getLogger(DbUtil.class);
    +    public final static Logger s_logger = Logger.getLogger(DbUtil.class);
    --- End diff --
    
    Just curious why we went from protected to public here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message