Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: DaanHoogland <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-637-cloudstack@git.apache.org>
In-Reply-To: <git-pr-637-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Cloudstack 8656 adding messages to
 empty ...
Content-Type: text/plain
Message-Id: <20150730064326.E0613E69F3@git1-us-west.apache.org>
Date: Thu, 30 Jul 2015 06:43:26 +0000 (UTC)

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/637#issuecomment-126202911
  
    @koushik-das, Ignoring interrupted exceptions means that you do not allow the user or other threads to interrupt you. To me that seems serious. I did not in any case see comment about why it was done so I rigorously added the messages.
    As for level; On one hand you are right @wilderrodrigues , as some errors that have been ignored in the past have been problems. On the other hand, someone did think it was safe to ignore those errors. The real job is to asses all the messages on level but I regard that out of scope for this PR. Maybe some of them should be WARN or even ERROR and others merely DEBUG or TRACE. I put the tag [ignored] there so we know we must considder them for either proper handling or another level of logging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---