Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: wilderrodrigues <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-627-cloudstack@git.apache.org>
In-Reply-To: <git-pr-627-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8668: VR type in shared
 networ...
Content-Type: text/plain
Message-Id: <20150729082159.C75F2DFB3B@git1-us-west.apache.org>
Date: Wed, 29 Jul 2015 08:21:59 +0000 (UTC)

Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/627#issuecomment-125878438
  
    Nice catch, @kishankavala !
    
    I checked the history of the file and found out that the changes for VPC router and normal router were added in the commit 13b7ca1b3fc3d3c44d677307a59a5205b6c881bb
    
    The extra iff you added, for the dhcpsrvr case, will do it.
    
    Do you want to create a new PR for that one? I can test it as well. Since it's touching only dhcpsrvr (used for basic zones) I'm not expecting problemas with VPC routers or other routers used for advanced zones.
    
    Cheers,
    Wilder 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---