Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: karuturi <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-609-cloudstack@git.apache.org>
In-Reply-To: <git-pr-609-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query
 nested g...
Content-Type: text/plain
Message-Id: <20150722083129.69D8AE17F1@git1-us-west.apache.org>
Date: Wed, 22 Jul 2015 08:31:29 +0000 (UTC)

Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/609#discussion_r35191354
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java ---
    @@ -57,17 +57,22 @@
         private LdapContextFactory _ldapContextFactory;
     
         @Inject
    -    private LdapUserManager _ldapUserManager;
    +    private LdapConfiguration _ldapConfiguration;
    +
    +    @Inject LdapUserManagerFactory _ldapUserManagerFactory;
    +
     
         public LdapManagerImpl() {
             super();
         }
     
    -    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManager ldapUserManager) {
    +    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManagerFactory ldapUserManagerFactory,
    +                           final LdapConfiguration ldapConfiguration) {
    --- End diff --
    
    It was initially done that way. We could inject as well. I did that in the new class.
    
    -----Original Message-----
    From: "Daan Hoogland" <notifications@github.com>
    Sent: ‎22-‎07-‎2015 13:18
    To: "apache/cloudstack" <cloudstack@noreply.github.com>
    Cc: "Rajani Karuturi" <rajanikaruturi@gmail.com>
    Subject: Re: [cloudstack] CLOUDSTACK-8596 ability to query nested groups forMicrosoft AD (#609)
    
    In plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java:
    >  
    >      public LdapManagerImpl() {
    >          super();
    >      }
    >  
    > -    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManager ldapUserManager) {
    > +    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final LdapUserManagerFactory ldapUserManagerFactory,
    > +                           final LdapConfiguration ldapConfiguration) {
    And why not use injection for that as well? Is this a groovy thing?
    —
    Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---