Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: resmo <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-601-cloudstack@git.apache.org>
In-Reply-To: <git-pr-601-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8650: Fix securitygroups
 ingre...
Content-Type: text/plain
Message-Id: <20150722072120.D28B2E17F6@git1-us-west.apache.org>
Date: Wed, 22 Jul 2015 07:21:20 +0000 (UTC)

Github user resmo commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/601#discussion_r35187102
  
    --- Diff: scripts/vm/network/security_group.py ---
    @@ -860,8 +860,10 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
                     for ip in ips:
                         execute("iptables -I " + vmchain + " -p icmp --icmp-type " + range + " " + direction + " " + ip + " -j "+ action)
     
    -        if allow_any and protocol != 'all':
    -            if protocol != 'icmp':
    +        if allow_any
    --- End diff --
    
    missing ":"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---