Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91D10180E1 for ; Wed, 22 Jul 2015 07:11:36 +0000 (UTC) Received: (qmail 7570 invoked by uid 500); 22 Jul 2015 07:11:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 7513 invoked by uid 500); 22 Jul 2015 07:11:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 7502 invoked by uid 99); 22 Jul 2015 07:11:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jul 2015 07:11:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DCB90E17F6; Wed, 22 Jul 2015 07:11:32 +0000 (UTC) From: karuturi To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima... Content-Type: text/plain Message-Id: <20150722071132.DCB90E17F6@git1-us-west.apache.org> Date: Wed, 22 Jul 2015 07:11:32 +0000 (UTC) Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/606#issuecomment-123585585 Yes. Copy paste error :) -----Original Message----- From: "Wido den Hollander" Sent: ‎21-‎07-‎2015 21:19 To: "apache/cloudstack" Cc: "Rajani Karuturi" Subject: Re: [cloudstack] CLOUDSTACK-8648: Do not configure the ImageFormat Processor when fetc… (#606) Shouldn't we then pass "params" to the configure method? That seems to be missing in your example. — Reply to this email directly or view it on GitHub. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---